Well, one Travis job has failed, I've restarted it, if it goes green (I
think it would) I'm going to merge the PR.
<rant>
I feel your pain. All I can do is, do what life allows me to do. We have
to live with that. I hope some rants would wake some people up here, but
life can be demanding as well.
Mereging crap? That's possible even when reviewed. I've done it a few
times. Though the my intentions were good, and those craps eventually
got fixed. I'd still vote for trust, than a pile of non-integrated PR-s.
</rant>
On 10/7/20 8:28 AM, Ernie Rael wrote:
Currently fxml code completion in a modular java project doesn't work.
https://github.com/apache/netbeans/pull/2399
ping@sdedic <https://github.com/sdedic>@jlahoda
<https://github.com/jlahoda>Your comment have been incorporated. Can
we finish this?
CC:@lkishalmi <https://github.com/lkishalmi>
Of course, one way to finish it is to decline it.
<rant>
I remember there was some discussion a while ago about default
behavior in PR handling, including something about merging after a
while if no objections. Emotionally I like that, but practically
(IMHO, given the level of PR review activity) either junk would be
merged possibly evolving into PRs declined out of hand because no one
has the time to review; which all seems worse than the current situation.
</rant>
-ernie
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
