Am Sonntag, den 03.01.2021, 13:39 -0600 schrieb Eric Bresie: However I noticed the following possible further issues: (1) When dealing with many of the properties files, it seemed to strip comments starting with # all together. Assume this may require changes to the logic where it's replacing the header to avoid this.
It would help if you could provide a stand-alone sample, that reproduces the problem. I won't comment one theoretic questions without reference. (2) If there is no header presently, it does not modify this. Assume this would be a case where when an existing header is not present then add it as well where applicable Running "ant rat" on a clean tree (no build artifacts) will check the files for licenses. It highly depends on the number of files that are affected whether or not automation will help. You will never get 100% succcess for this, the tools are there to help, not make all work go away. (3) When iterating through, it seems to iterate through some binary files (i.e. class and jar files). Not sure if it tries to modify these but seems like that might be unnecessary. Maybe need some additional "exclude" logics with some defaults included in some way (maybe a properties file with exclusions or a parameter with exclusions included) There should be no binaries in the tree when the tool runs - even so, it should be trivial to exclude these, either from the scan/modification or the final commit. If I was to make some of these changes, are changes for this tracked in the Netbeans JIRA (i.e. does a ticket need raising here or elsewhere [git Issue?]). Or would making the changes with a PR suffice? The netbeans-tools are a mixed bunch of code. For the convert tool fixing it with a PR and maybe getting a second opinion should be enough. Greetings Matthias --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
