Thank you for your support of https://github.com/apache/netbeans/pull/2761 I hope we are getting closer to allow building of NetBeans on any JDK8+.
Laszslo approved it yesterday (thank you) and added a request to squash the commits. How exactly do you want the commits to be squashed? Into a single commit? But then we loose the history and motivation for doing the changes! From the [list of commits ready so far](https://github.com/apache/netbeans/ pull/2761/commits) I consider following commits marked with ! essential: ! Let's upgrade javac.target to 1.8 across the code base ! By default use javac.target 1.8 ! Set release based on javac.target unless -Xbootclasspath flag is spec… ! Disable release flag by setting bootclasspath ! setRelease has been added in Ant 1.9.8 Avoid access to sun.security.util package in the test Removing the old bytecode test ! JDK11's javac doesn't like $ in Class-Path attribute ! Removing the -Dpermit.jdk9.builds=true flag Skip the api.htmlui tests if JFXPanel cannot be instantiated Skip the tests if JavaFX cannot be initialized Don't test JavaFX Ant project when there is no JavaFX Only perform the test when JFXPanel is available ! Validate the generated class files can be executed on JDK8 ! Always specify target/release when using javac I am not huge fan of "squashing" in general, but I can live with it from time to time. However in the [PR-2761](https://github.com/apache/netbeans/pull/ 2761) I tried my best to let the commits speak for themselves and explain what is their purpose for example when using `git blame`. I believe some of the "!" commits turned to be rightfully separate commits. If you look at the discussion in https://github.com/apache/netbeans/pull/2761 - I was able to respond to certain questions by pointing to the actual commit. Its title explains the motivation, its diff shows what has changed. Do we really want to squash #2761 into a single commit? Do we want to keep at least some (of the "!") commits? Do we leave it as it is and merge? Thanks for your suggestions. I'll do what seems to be the preferred choice and hopefully integrate before my vacation is over (end of Feb 2021). -jt --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
