Well,
I acknowledge and see the added value by the VS Code movement.
I do not think that having an LSP Gradle module for customizing actions
would mean a "fork".
It'd mean that LSP has another way to customizing execution. Which seems
to be true. So a bridging module would be Ok.
However if you find the current NB Gradle API too weak, we can talk
about that even on-line through Slack.
I just would like to avoid to have an action customization SPI, and
another SPI to infiltrate more Gradle Options into the command line.
However if there is a strong reason that supports the need, I can be
convinced.
On 3/9/21 1:55 AM, Jaroslav Tulach wrote:
So at worst, a supposed "LSP Gradle" module would provide a
replacement for project run, debug, profile actions + suck (somehow)
the rest of actions from standard Gradle support ?
That's what I've meant, and yes fallback to the existing implementation
needs some love in the code to be possible.
Hello Laszlo,
when the Apache NetBeans Language Server Extension effort started, one of
the common worries was: isn't that forking NetBeans?
It is a valid worry, but I believe that so it has been demonstrated that
our effort to provide a VSCode extension can help NetBeans overall. The set
of contributions to NetBeans 12.2, which wouldn't be possible otherwise,
speaks for itself:
https://github.com/apache/netbeans/pull/2471
https://github.com/apache/netbeans/pull/2464
https://github.com/apache/netbeans/pull/2427
https://github.com/apache/netbeans/pull/2393
https://github.com/apache/netbeans/pull/2309
https://github.com/apache/netbeans/pull/2523
https://github.com/apache/netbeans/pull/2424
https://github.com/apache/netbeans/pull/2407
https://github.com/apache/netbeans/pull/2396
https://github.com/apache/netbeans/pull/2390
https://github.com/apache/netbeans/pull/2360
https://github.com/apache/netbeans/pull/2358
https://github.com/apache/netbeans/pull/2481
https://github.com/apache/netbeans/pull/2474
https://github.com/apache/netbeans/pull/2467
https://github.com/apache/netbeans/pull/2452
https://github.com/apache/netbeans/pull/2436
https://github.com/apache/netbeans/pull/2429
Overall I am trying to argue in favor of sharing as much as possible
between VSNetBeans and regular NetBeans IDE. As such I am worried about the
need for special "LSP Gradle" module
a supposed "LSP Gradle" module would provide a
replacement for project run, debug, profile actions
that would just contribute to "forking" the code base. I'd like to avoid
such module and rather come up with good enough abstractions in the base
implementation.
-jt
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
