Thanks for your comments Neil... @ May 27 2021 @ > On Wed, 26 May 2021 at 09:45, Jaroslav Tulach <jaroslav.tul...@gmail.com> wrote: > > Do you think these wrappers and the build script should become part of a > > NetBeans repository? Or is it better to get it working in a separate > > repository - like the one I have? > > It can't be here can it, from a licensing perspective?
The GPL-CPE sources would remain hosted where they are - e.g. in the https://github.com/openjdk/jdk repository. The only thing that would need to be in here is the build script. I assume such build script can be Apache licensed. > However ... > > > Adding a RAT check to verify only "Classpath exception" files are imported > > from the OpenJDK repository would certainly be a step towards the > > desirable state and it could prevent human mistakes when releasing the > > bits. > > Ideally the aspect that verifies headers and builds from patched > sources would be here IMO, Such a verification would be in the build script. > then it's easier for PMC review of the > process, etc. +1 having the build script properly reviewed by PMC would simplify the verification of correctness The next question is: Should such build be part of regular NetBeans build? E.g. should it be invoked everytime someone invokes ```bash nbbuild$ ant build ``` Downside: The build requires checkout of the whole openjdk repository and even building takes quite some time. Consideration: there already is a build of `langtools-9.zip` in the build process. We could replace it by building nb-javac from sources PMC trusts? Alternative: Do it as with launchers: Regular users download pre-built binary. The final build runs from sources. I guess I'll continue working in my current repository for now with the goal to produce 100% working version. I'll keep in mind we want a system easily reviewable by PMC. I'll continue to assume that the build script assembling everything together can be Apache licensed. -jt > And we potentially get the basis of something that > could be used for other CPE dependencies here or in other ASF projects > should that arise. > > Best wishes, > > Neil > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
