I should note, it compiles and runs fine locally in my workspace ( https://docs.google.com/document/d/1ua48Uu6OTKNkcG_9sQOOicl5JpjrBtMgSy4SSjumAuU/ )…it’s the commit validation checks that assume enforce some quality and API versioning checks here (given its older code probably has need fir api updates).
On Fri, Jun 25, 2021 at 4:14 PM Eric Bresie <[email protected]> wrote: > Yes I ran > > For MacOS build > ant -Dcluster.config=release commit-validation > > For Commit-validation (on Linux) > ant -Dcluster.config=release commit-validation > > which reproduce one of the problem locally which led me to find one of the > problems mentioned in this thread. Which leads me here requesting guidance > on how to migrate between old and new apis. > > > On Fri, Jun 25, 2021 at 3:17 PM Matthias Bläsing < > [email protected]> wrote: > >> Hi, >> >> I won't chase through the log files to see what you mean. But looking >> at the end I see: >> >> >> >> /home/runner/work/netbeans/netbeans/nbbuild/build/test/commit-validation/results/TEST-org.netbeans.core.validation.ValidateModulesTest.xml >> >> This is in `platform/o.n.core` -> Functional Test Packages -> Package >> org.netbeans.core.validation, Class ValidateModulesTest >> >> /home/runner/work/netbeans/netbeans/nbbuild/build/test/commit-validation/results/TEST-org.netbeans.modules.ide.ergonomics.DynamicVerifyTest.xml >> >> >> This is in `ergonomics/ide.ergonomics` -> Unit Test Packages -> Package >> org.netbeans.modules.ide.ergonomics.DynamicVerifyTest, Class >> DynamicVerifyTest >> >> >> Both test suites can be run from the IDE. The integration tests are the >> last line of defense, when they trigger I try to reproduce the issue >> localy, you won't get happy trying to guess the reason from the log >> output in the CI/CD pipeline. >> >> From the direction of the tests I suspect, that the module setup you >> build is broken somewhere and needs to be fixed (dependencies >> missing?). >> >> HTH >> >> Matthias >> >> >> Am Freitag, dem 25.06.2021 um 14:53 -0500 schrieb Eric Bresie: >> > While working Python code (still waiting on the donation by the way) >> I’ve >> > been working on previous, when commits were made in my branch/fork, the >> > auto build checks unit check failed on the following unit test >> > >> > > > deprecatedModulesAreDisabled Failure Some deprecated modules are in >> use >> > > > org.openidex.util is deprecated and should not be enabled >> > >> > See failed checks at >> > https://github.com/ebresie/netbeans/actions/runs/951354974 >> > >> > Which seems to me to imply >> > >> > “org.openidex.util is deprecated and should not be enabled” >> > >> > Assume this means, it’s an old API that needs to migrate to a new API >> (i.e. >> > believe org.netbeans.api.search.*) >> > >> > Was trying to determine if there was any details, documentation, or >> > examples projects where something similar migration had been done from >> > org.open index.util to new applicable API. >> > >> > Eric >> > >> > On Sun, Jun 20, 2021 at 1:22 PM Geertjan Wielenga >> > <[email protected]> wrote: >> > >> > > Here’s your description of the problem, if you can fill in the gaps >> here, >> > > explain what it means, provide some kind of context, steps to >> reproduce the >> > > problem, then people can help you (otherwise your frustration will >> continue >> > > and your feeling that no one is responding, rather than no one >> > > understanding the context, will continue): >> > > >> > > “While running one of the unit tests against old code migrated in, I >> get >> > > the failure shown at the end of this thread.” >> > > >> > > Gj >> > > >> > > >> > > >> > > On Sun, 20 Jun 2021 at 20:12, Eric Bresie <[email protected]> wrote: >> > > >> > > > Am I assume it would involve changing over >> > > > >> > > > From packages/classes like: >> > > > >> > > > org.openidex.search.SearchInfo >> > > > org.openidex.search.SearchInfoFactory >> > > > >> > > > To packages/classes like: >> > > > => org.netbeans.api.search.provider.SearchInfo >> > > > => org.netbeans.spi.search.SearchInfoDefinition >> > > > => org.netbeans.api.search.provider.SearchInfoUtils >> > > > => org.netbeans.spi.search.SearchInfoDefinitionFactory >> > > > >> > > > Not quite sure the difference between SearchInfo vs >> SearchInfoDefinition. >> > > > >> > > > There also seems to be some File Object, Child/Root type classes >> involved >> > > > which I'm not sure how best to migrate over quite as cleanly (i.e. >> some >> > > > things have changed from interfaces to abstract classes, some more >> > > > specialized to I suspect more generalized high level new API, etc.) >> > > > >> > > > Is this sort of thing documented someplace (either in mailing list, >> wiki, >> > > > API, other classes already migrated, etc.)? >> > > > >> > > > Eric Bresie >> > > > [email protected] >> > > > >> > > > >> > > > On Sun, Jun 20, 2021 at 9:46 AM Eric Bresie <[email protected]> >> wrote: >> > > > >> > > > > While running one of the unit tests against old code migrated >> in, I >> > > get >> > > > > the failure shown at the end of this thread. >> > > > > >> > > > > I suspect this has to do with the code in question using an older >> > > > > deprecated API (specifically org.openidex.util and related Search >> > > > > classes). I assume the new API package may be >> org.netbeans.api.search >> > > > > >> > > > > Is there any details on how to migrate from this to an alternative >> > > newer >> > > > > API? >> > > > > >> > > > > I see references to org.openidex.util here ( >> > > > > >> > > > >> > > >> https://netbeans.apache.org/wiki/DevFaqLibrariesModuleDescriptions.asciidoc >> > > > > ) related to Servlet APIs which wasn't sure if this is correct. >> > > > > >> > > > > Display Name Module Comments >> > > > > org.openidex.util Servlet 2.2 API >> org.netbeans.modules.servletapi >> > > > > >> > > > > I find details about the org.netbean.api.search here ( >> > > > > >> > > > >> > > >> https://bits.netbeans.org/12.3/javadoc/org-netbeans-api-search/apichanges.html >> > > > > ), but I don't see any reference to org.openidex.util in the list. >> > > > > >> > > > > >> > > > > On maven central ( >> > > > > >> > > > >> > > >> https://search.maven.org/artifact/org.netbeans.api/org-openidex-util/RELEASE124/jar >> > > > > ) , I find reference to artifact name for org.openidex.util and >> > > > dependency >> > > > > like the below. Is this the likely migrate path? >> > > > > >> > > > > <groupId>org.netbeans.api</groupId> >> > > > > *<artifactId>org-openidex-util</artifactId>* >> > > > > <version>RELEASE124</version> >> > > > > <dependencies> >> > > > > <dependency> >> > > > > <groupId>org.netbeans.api</groupId> >> > > > > * <artifactId>org-netbeans-api-search</artifactId>* >> > > > > <version>RELEASE124</version> >> > > > > </dependency> >> > > > > >> > > > > ---- >> > > > > >> > > > > deprecatedModulesAreDisabled Failure Some deprecated modules are >> in use >> > > > > org.openidex.util is deprecated and should not be enabled >> > > > > >> > > > > junit.framework.AssertionFailedError: Some deprecated modules are >> in >> > > use >> > > > > org.openidex.util is deprecated and should not be enabled >> > > > > at >> > > > > >> > > > >> > > >> org.netbeans.core.validation.ValidateModulesTest.deprecatedModulesAreDisabled(ValidateModulesTest.java:274) >> > > > > at >> > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native >> > > > > Method) >> > > > > at >> > > > > >> > > > >> > > >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> > > > > at >> > > > > >> > > > >> > > >> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> > > > > at org.netbeans.junit.NbTestCase.access$200(NbTestCase.java:77) >> > > > > at >> org.netbeans.junit.NbTestCase$2.doSomething(NbTestCase.java:476) >> > > > > at org.netbeans.junit.NbTestCase$1Guard.run(NbTestCase.java:402) >> > > > > at java.base/java.lang.Thread.run(Thread.java:829) >> > > > > >> > > > > Eric Bresie >> > > > > [email protected] >> > > > > >> > > > >> > > >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >> -- > Eric Bresie > [email protected] > -- Eric Bresie [email protected]
