On Fri, Jul 2, 2021 at 12:12 PM Eric Bresie <[email protected]> wrote:

> Regarding
>
>    - NETBEANS-189 <https://issues.apache.org/jira/browse/NETBEANS-189> SQL
>    editor, shouldn't ask evertime to set the connection
>    - https://github.com/apache/netbeans/pull/2820
>
> I've created the following child ticket based on review comments from PR
> for this work
>
>    1. NETBEANS-5831 Create a SQL Standard Quoter for Use with
>    Connectionless Cases
>    2. NETBEANS-5474 <https://issues.apache.org/jira/browse/NETBEANS-5474> Add
>    SQL Hints for use during editing
>
> Regarding PR-2820
>
>    1. There is one "change requested" for which the change is against
>    outdated files with current changes (I believe) meeting the basic change
>    request
>    2. Maybe a github/PR-ism...For the "change requested" I don't appear
>    able to close it out . Does the "change requester" have to close it?
>    3. I'd like to close this PR out and include it in the next release
>    if possible.
>
> To test this this,
>
>    1. Pull the PR changes, build, and open netbeans,
>    2. Create a new sql file [File..New...Other..Sql file] (without any
>    connection set),
>    3. Start typing an sql statement (i.e. start typing an sql token like
>    "sel" or "ins" or "up")
>    4. Press "Ctrl + space" to auto complete.
>    5. When complete with SQL expression, press the "Run SQL Expression"
>    button
>    6. Close warning indicating need for connection.
>    7. Select connection
>    8. Start typing an sql statement followed by "autocompletion" of DB
>    based fields.
>    9. When complete with SQL expression, press the "Run SQL Expression"
>    button
>    10. Review results.
>
> See https://photos.app.goo.gl/N7NVMtKRF4D3kmCM6 for demonstration.
>
> Eric Bresie
> [email protected]
>
>
>
>
>

Reply via email to