I’ve asked you this in another thread but got no response — you have done so much work and rework on this pull request that it is hard to tell the wood from the trees. Probably almost nobody can review this PR anymore.
Are you able to explain and account for every statement you’re proposing adding to the repository? If so, can you create a Wiki page or something somewhere with step by step instructions so someone can see what exactly your pull request consists of (explain from scratch what we’re trying to achieve with this pr and precisely what code needs to be put where in our repo to achieve that)? If not, i.e., if you cannot account for each line of code that you’re proposing to add, if you have hacked things together here and there, if there are parts that you don’t completely understand or can’t explain — then you probably don’t want this code in our repo yourself, because then there’ll be a lot of problems that someone else (who? you?) will be fixing to potentially even get NetBeans even to start. Gj On Mon, 5 Jul 2021 at 02:20, Eric Bresie <[email protected]> wrote: > https://github.com/apache/netbeans/pull/2820 > > On Sun, Jul 4, 2021 at 6:50 PM Geertjan Wielenga > <[email protected]> wrote: > >> Can you point to the PR you’re referring to? >> >> Gj >> >> On Mon, 5 Jul 2021 at 01:12, Eric Bresie <[email protected]> wrote: >> >> > How’s does one get something approved? >> > >> > The last change requested was against old out of date files (changes >> were >> > made since then). I’ve seen no further comments, reviews and/or >> approval >> > for close to 3 months now beyond my own comment (with new ticket to >> address >> > the major architectural changes requested). >> > >> > Eric >> > >> > On Sat, Jul 3, 2021 at 10:32 AM Geertjan Wielenga >> > <[email protected]> wrote: >> > >> > > Once a PR has been approved and merged, let’s think about setting tags >> > and >> > > so on for it at that stage. >> > > >> > > Gj >> > > >> > > >> > > On Sat, 3 Jul 2021 at 17:16, Eric Bresie <[email protected]> wrote: >> > > >> > > > There is a JIRA ticket (NETBEANS-189 >> > > > <https://issues.apache.org/jira/browse/NETBEANS-189>) which allows >> > > labels >> > > > and target releases but github / PRs are different system(s). >> > > > I assume only official committers on the apache/netbeans with the >> > > > applicable roles and/or permissions are allowed to do so. >> > > > >> > > > So then am I correct in saying I will need an "official committer" >> to >> > do >> > > > so? >> > > > >> > > > Eric Bresie >> > > > [email protected] >> > > > >> > > > >> > > > On Fri, Jul 2, 2021 at 1:41 PM Piotr Hoppe <[email protected]> >> > wrote: >> > > > >> > > > > Did you check a JIRA ticket? >> > > > > >> > > > > Piotr >> > > > > >> > > > > W dniu 2021-07-02 o 19:42, Eric Bresie pisze: >> > > > > > How does one flag the milestone and/or labels of a PR? Are there >> > > > specific >> > > > > > steps or permissions needed? On a PR I'm working on I don't see >> > any >> > > > way >> > > > > to >> > > > > > do so or even if I'm allowed to. >> > > > > > >> > > > > > Eric Bresie >> > > > > > [email protected] >> > > > > > >> > > > > > >> > > > > > On Fri, Jul 2, 2021 at 11:03 AM Eric Barboni <[email protected]> >> > > wrote: >> > > > > > >> > > > > >> Just a reminder to all commiters please flag the milestone to >> 12.5 >> > > on >> > > > > merge >> > > > > >> it's ease to construct Release Note. >> > > > > >> >> > > > > >> >> > > > > >> > > > > >> > > > > >> --------------------------------------------------------------------- >> > > > > To unsubscribe, e-mail: [email protected] >> > > > > For additional commands, e-mail: [email protected] >> > > > > >> > > > > For further information about the NetBeans mailing lists, visit: >> > > > > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> > > > > >> > > > > >> > > > > >> > > > > >> > > > >> > > >> > -- >> > Eric Bresie >> > [email protected] >> > >> > -- > Eric Bresie > [email protected] >
