Hello everyone. I have tried fixing NETBEANS-5734 (JDK-Selection for Glassfish 6.1 is restricted to JDK 1.8) and since I may have some time available I would like to try and make a PR for it.
I need help not only because it's my first look inside Netbeans, but because it's almost 15 years since my last contribution to open source, and at that time it was all patches and SVN. I'm trying to get used to Github, but it will take some time till I can totally wrap my head around it, so please bear with me. I have made a commit on my fork to show what I have done till now, but IIUC to make a PR I should make a feature branch, do the commit there and make a PR. Since I committed on my master I guess I have to delete the fork and redo it... I'm really sorry but I thought it would be easier to grasp. This is the commit I have done: - https://github.com/nicolaken/netbeans/commit/672417e576d4f10b2a376d9337193823a126affb I really don't like the change in org.netbeans.modules.glassfish.common.StartTask.java, but don't know what else to do... Can someone take a quick look? Thank you in advance. -- Nicola Ken Barozzi [email protected] - Plans are worthless - but planning is everything.- Dwight D. Eisenhower, 17 Nov. '57.
