út 14. 9. 2021 v 21:44 odesílatel Brad Walker <[email protected]> napsal: > > Your friend Netbeans Rust Remover here.. I've been working on removing ALL > of the warnings related to ArrayList.. As a result, I have a questions > about how to make API changes. > > For example, notice the following. > > [repeat] > /home/bwalker/src/netbeans/ide/db.sql.visualeditor/src/org/netbeans/modules/db/sql/visualeditor/querymodel/OrderByNode.java:44: > warning: [rawtypes] found raw type: ArrayList > [repeat] public OrderByNode(ArrayList sortSpecificationList) { > [repeat] ^ > [repeat] missing type arguments for generic class ArrayList<E> > [repeat] where E is a type-variable: > [repeat] E extends Object declared in class ArrayList > > It's a fairly easy change to make this work w/ generics. But, at the end of > the day, this is a public API change.
Hello Brad. Why do you think it is a public API? Looking at https://github.com/apache/netbeans/blob/master/ide/db.sql.visualeditor/nbproject/project.xml#L113 I see only `org.netbeans.modules.db.sql.visualeditor.api` and `org.netbeans.modules.db.sql.visualeditor.querybuilder` packages being exported for consumption by other modules. > > > My understanding is an API change requires the following: > 1 - updating the apichanges.xml file > 2 - bump the spec.version in the project.properties files > > Is that all that is needed? Am I missing something? Try to run `ant gen-sigtest` to see API changes against recorded SigTest signatures. -jt > > -brad w.
