Does removing a package from the list of friend, make it public? Or does it need to be changed to something else?
I ask because of the comparison of different Java access possibilities in basic have (i.e. public, private, protected, default). On Tue, Nov 2, 2021 at 11:30 AM Laszlo Kishalmi <laszlo.kisha...@gmail.com> wrote: > > https://github.com/apache/netbeans/blob/4078eeb7c3ab73c21ce669f1a81b8477332afac1/ide/web.common/nbproject/project.xml#L197 > > > On 11/1/21 18:01, Eric Bresie wrote: > > Silly question, what is necessary to make API public(i.e. what file needs > > to be change)? > > > > On Sun, Oct 31, 2021 at 9:01 PM Laszlo Kishalmi < > laszlo.kisha...@gmail.com> > > wrote: > > > >> Just file a PR, that makes the API public. Generally we have no issue to > >> do so. The reviewers might take a brief look on the exported API-s, but > >> that's all. > >> > >> On 10/31/21 08:47, Eric Bresie wrote: > >> > >>> If so, what is the process by which this is normally done (i.e. change > >> from > >>> friend to public, any API documentation updates, any build changes, > >>> regression testing, etc.)? > >>> > >>> Eric Bresie > >>> ebre...@gmail.com > >>> > >>> Full stack trace: > >>> > >>> Failed to execute goal > >>> org.apache.netbeans.utilities:nbm-maven-plugin:4.6:manifest > >>> (default-manifest) on project python: Module has friend dependency on > >>> org.netbeans.modules.web.common.ui but is not listed as a friend. -> > >> [Help > >>> 1] > >>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to > execute > >>> goal org.apache.netbeans.utilities:nbm-maven-plugin:4.6:manifest > >>> (default-manifest) on project python: Module has friend dependency on > >>> org.netbeans.modules.web.common.ui but is not listed as a friend. > >>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute > >>> (MojoExecutor.java:215) > >>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute > >>> (MojoExecutor.java:156) > >>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute > >>> (MojoExecutor.java:148) > >>> at > >>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > >>> (LifecycleModuleBuilder.java:117) > >>> at > >>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > >>> (LifecycleModuleBuilder.java:81) > >>> at > >>> > >> > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > >>> (SingleThreadedBuilder.java:56) > >>> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > >>> (LifecycleStarter.java:128) > >>> at org.apache.maven.DefaultMaven.doExecute > (DefaultMaven.java:305) > >>> at org.apache.maven.DefaultMaven.doExecute > (DefaultMaven.java:192) > >>> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > >>> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) > >>> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) > >>> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) > >>> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native > >> Method) > >>> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke > >>> (NativeMethodAccessorImpl.java:62) > >>> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke > >>> (DelegatingMethodAccessorImpl.java:43) > >>> at java.lang.reflect.Method.invoke (Method.java:566) > >>> at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > >>> (Launcher.java:282) > >>> at org.codehaus.plexus.classworlds.launcher.Launcher.launch > >>> (Launcher.java:225) > >>> at > >> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > >>> (Launcher.java:406) > >>> at org.codehaus.plexus.classworlds.launcher.Launcher.main > >>> (Launcher.java:347) > >>> Caused by: org.apache.maven.plugin.MojoFailureException: Module has > >> friend > >>> dependency on org.netbeans.modules.web.common.ui but is not listed as a > >>> friend. > >>> at > >>> org.apache.netbeans.nbm.NetBeansManifestUpdateMojo.visibleModuleClasses > >>> (NetBeansManifestUpdateMojo.java:900) > >>> at > >>> org.apache.netbeans.nbm.NetBeansManifestUpdateMojo.checkModuleClassPath > >>> (NetBeansManifestUpdateMojo.java:717) > >>> at org.apache.netbeans.nbm.NetBeansManifestUpdateMojo.execute > >>> (NetBeansManifestUpdateMojo.java:561) > >>> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > >>> (DefaultBuildPluginManager.java:137) > >>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute > >>> (MojoExecutor.java:210) > >>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute > >>> (MojoExecutor.java:156) > >>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute > >>> (MojoExecutor.java:148) > >>> at > >>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > >>> (LifecycleModuleBuilder.java:117) > >>> at > >>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > >>> (LifecycleModuleBuilder.java:81) > >>> at > >>> > >> > org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build > >>> (SingleThreadedBuilder.java:56) > >>> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute > >>> (LifecycleStarter.java:128) > >>> at org.apache.maven.DefaultMaven.doExecute > (DefaultMaven.java:305) > >>> at org.apache.maven.DefaultMaven.doExecute > (DefaultMaven.java:192) > >>> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) > >>> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) > >>> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) > >>> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) > >>> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native > >> Method) > >>> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke > >>> (NativeMethodAccessorImpl.java:62) > >>> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke > >>> (DelegatingMethodAccessorImpl.java:43) > >>> at java.lang.reflect.Method.invoke (Method.java:566) > >>> at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced > >>> (Launcher.java:282) > >>> at org.codehaus.plexus.classworlds.launcher.Launcher.launch > >>> (Launcher.java:225) > >>> at > >> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode > >>> (Launcher.java:406) > >>> at org.codehaus.plexus.classworlds.launcher.Launcher.main > >>> (Launcher.java:347) > >>> > >>> > >>> For more information about the errors and possible solutions, please > read > >>> the following articles: > >>> [Help 1] > >>> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > >>> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > >> For additional commands, e-mail: dev-h...@netbeans.apache.org > >> > >> For further information about the NetBeans mailing lists, visit: > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >> > >> > >> > >> -- > > Eric Bresie > > ebre...@gmail.com > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > -- Eric Bresie ebre...@gmail.com
