java.lsp.server tests are known to fail [1] since (at least) 2022-03-06.
Basically we have a "while(true) {}" block in "ConnectionSpec" [2] that loops forever.
We had a PR a while back, but it didn't attract much interest. A possible solution is to catch a SocketException and break the loop then as in [3].
Also Google's GSON cannot deserialize different JSON objects coming from the LSP server through the wire, as the NetBeans POJOs don't have a proper constructor/are not created using a factory object. See [4] for an example. You can run "ant test" in java.lsp.server to verify this.
I understand there's a lot of activity (and interest) in having java.lsp.server out quickly, but we may want to think twice how we got to this "master is unstable" situation, and how to proceed forward, so this does not happen again.
As an immediate countermeasure I propose freezing all PR merges until master is stable.
Cheers, Antonio [1] https://github.com/apache/netbeans/issues/3716 [2] https://github.com/apache/netbeans/blob/385dbd3ca71f1643dde025deb18ed2e75a714005/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ConnectionSpec.java#L112 (Note this under the "src" folder, i.e., it's not a unit test file). [3] https://github.com/apache/netbeans/pull/3717/files#diff-99d2e9352dee99afecc8f129ce088efcbf7b3649f966a27e929dc7a8a2a507e6 [4] https://github.com/apache/netbeans/pull/3717 El 20/4/22 a las 14:48, Michael Bien escribió:
the failing test which the failing jobs have in common: org.netbeans.modules.java.lsp.server.protocol.ServerTest failed: testHover errored: testMain
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
