sure, we can run like this for a while but it will be painful (for
everyone) to have often failing tests in gh actions additionally to
travis. It can also cause other issues. If someone isn't restarting them
we might max out our artifact storage. And if they are not restarted
within a day, we have to restart EVERYTHING to get new build artifacts.
We are lucky here that the job itself is short. If it would be in a 1h+
job that would be a showstopper IMO.
Matthias already spent time to try to fix this, there is no lack of
trying. We don't have much room left to make tests more unreliable.
best regards,
michael
On 09.06.22 20:13, Svata Dedic wrote:
I have very bad experience with turning off integration tests. And
consistency of the registrations is ultimately important. We can
easily go unnoticed to the situation when the IDE simply does not
start because of broken layer.
I've fixed similar situation in the past (after some time without
proper tests) and would appreciate not to go through the hell again.
-S.
Dne 09. 06. 22 v 19:10 Michael Bien napsal(a):
On 08.06.22 20:54, Matthias Bläsing wrote:
Hi again,
Am Montag, dem 06.06.2022 um 09:05 +0200 schrieb Jaroslav Tulach:
2022-05-29T17:06:31.9092439Z [junit] java.lang.AssertionError: Has
to be NbRepository: org.openide.filesystems.Repository@744b325b
2022-05-29T17:06:31.9093232Z [junit] at
org.netbeans.core.startup.Main.start(Main.java:298)
2022-05-29T17:06:31.9094120Z [junit] at
org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:98)
2022-05-29T17:06:31.9094571Z [junit] at
java.lang.Thread.run(Thread.java:750) 2022-05-29T17:06:31.9095235Z
[junit]
Isn't this caused by some race condition? Temporarily adding
`this.when = new
Exception("initialized")` into `Repository` constructor and printing
the
stacktraces when the `AssertionError` happens might tell us who's
responsible
for the misconfiguration of the test.
This is a very nice way to catch this - thank you for the idea. I had
to slightly alter it, but I got a stack trace.
I decided to go ahead with merging the PR and see how it develops in
the next few days.
I filed an issue to hold information about that problem:
https://github.com/apache/netbeans/issues/4211
Then at least there is a record of it and it can be further analysed.
Greetings
Matthias
Hi,
we are lucky that the test is on a job which doesn't take very long
to run, but It might be good to consider to disable it anyway for now.
I had to run it 4 times here:
https://github.com/apache/netbeans/actions/runs/2465738672
and twice here:
https://github.com/apache/netbeans/actions/runs/2468718859
since this is in a 4x matrix, basically every commit will likely fail
and someone has to restart something.
you can see it here:
https://github.com/apache/netbeans/commits/master
no hurry since this is still somewhat manageable i believe, but it
would be better to turn it off until resolved IMO.
best regards,
michael
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
