On Thu, 11 Aug 2022 at 00:23, Michael Bien <[email protected]> wrote: > Usually push only happens on merge (since that counts as push too), if > you sync two branches on our main repo (not from clone to main), you > would push into one branch and create a PR from it. Which means it > builds the same hash twice just for the PR (and a third time on merge). > You would see every check twice below the sync PR, one marked with push > and one with pull_request. Unfortunately it doesn't show that on closed > PRs and we don't have one open atm.
I'm aware of the two checks. My point was that they're not the same hash, on GitHub or Travis, as far as I know. The branch tests run on the head of the delivery branch (refs/head/delivery). The sync PR tests run on the pending result of the merge to the base branch (refs/pull/<ID>/merge), eg. master. Now the result of merging to releaseXXX is usually not interesting. Testing on the result of merging to master can (and occasionally does) highlight concerns. Which we can then try to address *before* merging syncs to the two branches. PRs into delivery have usually been tested against delivery, not master. This is a reason for opening the sync PRs as soon as delivery has changes. This is somewhat of a tangent to your original post - just pointing out that full CI on sync PRs is deliberate at the moment. We could change procedures if you think there's a better way to achieve the above. Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
