OMG! Just had some time to look at this. Unfortunately, I think it is serious. Due to wrong bit-shifts the id-s for MAC_OS and LINUX has been changed, which would mean a serious incompatibility as AFAIK the compiler puts actual value of these fields into the bytecode. That would cause third-party plugin compatibility issues whenever the plugin would use those constants directly. I hate to say it, but I think it is a reason for RC4
Do we have a PR fixing those bit-shifts or shall I create one? On Wed, Aug 10, 2022 at 1:34 AM Neil C Smith <[email protected]> wrote: > Hi, > > I generated the API snapshot sigtest file for review yesterday. > Ideally we need to review earlier in the release process, but for a > number of reasons they haven't been generated until now ... > > https://github.com/apache/netbeans/pull/4487 > > One thing that stands out to me is the changes in compile time > constants inside Utilities introduced by > https://github.com/apache/netbeans/pull/4025 > > I'm not sure how much of an issue that might be in practice, and > whether it's a reason to run an rc4? Review welcomed! > > Thanks, > > Neil > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
