I’ve run into this elsewhere - if you’re naively triggering off of pushes using GitHub actions, well, when someone clones your repo, they’re also cloning your actions, and if they reach out to something to trigger a build (or in the case where I ran across this, publishing notifications to Zulip), well, something is going to be triggered.
Either the action could mark itself as skipped when the repo url is not what it expects, or the thing called could (if the caller sends it and does not lie). -Tim On Wed, Oct 12, 2022 at 11:58 AM Michael Bien <mbie...@gmail.com> wrote: > On 12.10.22 17:10, John Neffenger wrote: > > On 10/12/22 3:00 AM, Michael Bien wrote: > >> if you clone the project you getting the same behavior, just on your > >> own copy. > > > > Thank you, Michael. Four years in, and I'm still learning GitHub. :-) > > So am I :). Some of the features we enabled recently are fairly new. 1-2 > years ago i wouldn't recommend gh actions for large projects due to its > limitations. But it is getting better now. > > > > > >> its defined on the very top of the .github/workflows/main.yml file in > >> your master branch. > > > > Got it. I see now that the other projects I'm familiar with (JDK and > > JavaFX) simply exclude the master branch: > > > > https://github.com/openjdk/jdk/blob/master/.github/workflows/main.yml > > > > on: > > push: > > branches-ignore: > > - master > > - pr/* > > > > https://github.com/jgneff/jfx/blob/master/.github/workflows/submit.yml > > > > on: > > # Run GitHub actions on every push to all branches except the main > > # production branches, also exclude any branch starting with "WIP". > > push: > > branches-ignore: > > - master > > - main > > - 'jfx[0-9]+' > > - 'WIP*' > > we actually do want to run tests on master when a PR is integrated (PR > merge is just a push). We did setup a conditional pipeline a few days > ago. PRs run tests based on their labels, push (e.g a merge) to master > runs everything. > > Its likely that we are going to have to change this one day, since > running all tests on merge might be too much for the limited node runner > resources apache has. We test much less in PRs now, but more on master. > > JDK uses a fairly advanced setup which sidelines github a bit. (e.g > there is no merge button, its a command). > > https://github.com/openjdk/skara > > > > > > I thought that was somehow built-in behavior. Maybe this is the first > > time the tests ran because I'm no longer a first-time contributor? > > > > > https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks > > > > > > About workflow runs from public forks > > > > "To help prevent this, workflows on pull requests to public > > repositories from some outside contributors will not run > > automatically, and might need to be approved first. By default, all > > first-time contributors require approval to run workflows." > > the NB repo has this enabled. PRs from non-committers would not trigger > CI until someone approves the workflow run. > > Btw I am 99% sure that actions on clones don't actually run on apache > resources, it would use your account I believe. So watch out or you > might reach your monthly limit - NB tests a lot. > > > > > > For now, I switched to "Disable actions." > > right. Most clones don't need actions since opening a PR does already > everything you need. > > best regards, > > michael > > > > > > Thanks again, > > John > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > > For additional commands, e-mail: dev-h...@netbeans.apache.org > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > -- http://timboudreau.com
