On 16.10.22 13:04, Michael Bien wrote:
On 16.10.22 12:11, Neil C Smith wrote:
On Sun, 16 Oct 2022 at 10:56, Michael Bien <mbie...@gmail.com> wrote:
I believe the upcoming RC phase of NB 16 will overlap with the release
of JDK 19.0.1 again, which means there might be another opportunity to
upgrade later.
Yes. Well, if there are bug fixes in javac that might affect the IDE
anyway. I see no reason to treat nb-javac differently to how we treat
bug fixes elsewhere.
+1
I think the safest approach would be to upgrade to 36 now and decide
later if we want to take a new build based on 19.0.1. We could also
wait, skip build 36 and go directly to 19.0.1 but this would be
riskier.
Agreed. Makes sense to get this in for rc1, even if we need to delay
freeze slightly? Or at least put it through delivery before rc1 is
built?
tbh i would lean towards of not delaying rc1 because of this. (+ there
is the hope that nb-javac might arrive in time). But you are the boss :)
opened a PR here (only a property change):
https://github.com/JaroslavTulach/nb-javac/pull/10
Which can hopefully be expedited quickly. One of the issues with
nb-javac being that we cannot develop and release it here!
yes. the current situation is a bit annoying :/
The thing is: NB doesn't actually need nb-javac anymore. nb-javac used
to be a fork, with modifications which made it better suitable to be
used by an IDE. But that is no longer the case.
We could work towards removing the nb-javac dependency and let the
installer install a matching JDK using the foojay API (user picks the
vendor) and bump the requirements of the zip accordingly.
just to clarify: it doesn't even have to be an installer, NB itself
could check during boot if the runtime JDK meets the requirements, and
if it doesn't -> offer to download one which does.
-mbien
Since all we have to do is to match the runtime JDK with the NB
release. This would simplify a lot, since there are other advantages
of shipping on an up2date JDK (e.g no weird JDK selection code for the
hints, significantly reduced CI complexity, better out-of-the-box
experience due to latest JVM/JDK updates etc, and yes the option to
use current APIs and language features for selected modules if someone
actually wants to do that).
(your community installer is basically already doing this:
https://www.codelerity.com/netbeans/ ;))
best regards,
michael
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
