On Tue, 10 Jan 2023 at 14:21, Michael Bien <mbie...@gmail.com> wrote: > The commit validation job is currently testing on 8, 11, 17 and 20-ea. > It doesn't like NetBeans editor modules which require java 11 though > which blocks a Jakarta EE 10 PR atm (#4692). > > This means we need either 1) a volunteer who would like to spend time > and fix JDK 8 tests, 2) we remove JDK 8 from the CV test matrix or 3) we > won't be able to merge this pr before freeze.
IMO, we could possibly disable the JDK 8 commit validation temporarily. I think we might have a test issue here, that is not specific to JDK 8, and will rear its head with higher Java dependencies later anyway. However, it's (more) likely the test failure is pointing out a valid dependency misconfiguration in this PR given how it was agreed we'd support higher Java versions, with optional enablement based on OpenIDE-Module-Java-Dependencies. Why does this PR fail but existing modules don't?! Maybe my suggestion on the PR was wrong about using OpenIDE-Module-Recommends, at least by itself - the existing modules with higher than JDK 8 requirements all use OpenIDE-Module-Provides to enable them I believe? Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
