Dear Łukasz,
Just imagine, that life is not binary, not black and white, there are
pro-s con-s about each of the mentioned items.
And as you noticed we have a discussion about it. When you file a code
cleanup PR, it is an art to find the balance between the lines.
Though:
1. We welcome contributors!
2. We want reasonable sized PRs (that's a debate what and when something
is reasonable)
3. We want reasonable sized PRs
4. We want to have more tests, though new tests should be meaningful
(increase the code coverage, or highlight a specific case.)
5. There are different qualities of tests where they could be good or
needs to be improved
6. It's a large and 20+ years old codebase. We treat our tests very
conservatively. New tests are welcome. Changing old test for the sake of
change/modernization shall be well reasoned/debated.
7. Code cleanup PRs are under discussion.
8. We welcome contributors! Like it or not, every PR has a value/noise
ratio. Fixing a corner case NPE might not be an impactful PR, but could
have higher value/noise ratio, than a code cleanup PR.
9. We shall improve on that. I take the note.
10. Plugin on the portal and keeping compatibility are two very
different things.
On 1/28/23 07:19, Łukasz Bownik wrote:
Hi.
I read the latest discussions and as a relatively new contributor I got
contradictory guidance/experience. What I generally refer to is (in no
particular order):
1. "we welcome contributions" vs "we want less noise"
2. "we want small PRs" vs "we want big PRs"
3. "we want small PRs" vs "we want to save CI resources"
4. "we want new tests" VS "we already have too many tests"
5. "our tests are not good enough" vs "out tests already run for hours"
6. "we want to improve our tests" vs "test improvement PRs are noise"
7. "we want to keep code clean" vs "code cleanup PRs are noise"
8. "we welcome new contributors" vs "we want high value/impact PRs from day
one"
9. "we want contributors to talk to to us" vs "we ignore emails from them"
10. "we want 100% backward compatibility" vs "we let plugins to disappear
from the 'available' list all the time"
So I think it might be a good idea for the core theme to sit, discuss and
create a document ironing out these issues and laying a general process
that should be followed by contributors.
Best regards.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
