Hi Michael,
Refactoring the code because of aesthetic, academic or modernization
reasons is a non-ending task in a >500KLOC codebase that will turn 27
this year. By the time we end up modernizing all the code it will then
be outdated.
IMHO we need contributors that are conscious of the implications of the
changes they propose, that run this extra mile that requires thinking
and explaining us the pros and cons, and the value they want to add to
the project.
IMHO it's our responsibility to request these explanations to
contributors, otherwise we'll end up stuck in a never-ending loop of
reviewing a codebase that will turn 27 this year. These discussions, as
you say, should be done in the mailing list, and not in a PR _after_ the
code has been submitted.
Cheers,
Antonio
On 27/1/23 17:42, Michael Bien wrote:
[...]
Another example are generics, which is super tiresome to review - this
has to be split up.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
