Ah. Good spot. I did not recognize that the DocumentBuilder is coming from the JSF Implementation.

So you'd keep it that way to let the implementation decide of the schemas should be validated or not?

Greetings
Benjamin


On 2023-07-04 03:06, Matthias Bläsing wrote:
Hi Benjamin,

Am Montag, dem 03.07.2023 um 20:01 +0800 schrieb Benjamin Asbach:
During the work on the support I wanted to extend this part to support
jakarta namespaces:

https://github.com/apache/netbeans/blob/2edeaf99fc099b754b234600dbc491f0449659b0/enterprise/web.jsf.editor/src/org/netbeans/modules/web/jsf/editor/facelets/mojarra/ConfigManager.java#L1062-L1153

Basically it parses `tablib.xml` files and this part seems to try to
validate that xml via a schema based on the version of the `taglib.xml`.

But while debugging I could not find a scenario where
`builder.isValidating()` is returning `true`.

Does anybody know more on this part of the code? Can it be removed?
Should it get fixed somehow so that the schema is validated?

having a quick look at this I read it like this:

The DocumentBuilder that is use dto parse the taglib comes from mojara
itself, which in turn uses a default instance.

So the builder you get and its configuration is outside your control. I
assume, that at some point in time, schemas and URLs were taken
seriously and at that point it might have been a validating parser.
Maybe the developers of NetBeans implemented the support in that
timeframe.

Greetings

Matthias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to