Hi, I'm rebuilding my daily-driver with both #7928 and #8009 applied. Not sure how much work will really happen in the IDE the next week, but I'll try to see how it goes.
Thank you for working on this. Given Javas current approach, I think we should go ahead after some testing. Greetings Matthias Am Sonntag, dem 15.12.2024 um 20:18 +0100 schrieb Michael Bien: > On 15.12.24 19:33, Geertjan Wielenga wrote: > > Great. What’s the danger or problems with not doing this, > > the windows launcher sets a hard coded JVM option for the security > manager which will now cause a JVM startup failure on JDK 24. > > If the flag is not removed, NB 25 won't start on windows / JDK 24 - no > matter which of the followup PRs is merged (new agent layer or SM > removal proposal). (see other discussion thread). > > step 1) and 2) do only _move_ the flag from the binary windows launcher > to the netbeans conf. The actual removal would happen in the PR which > handles the actual JDK SM removal. > > > i.e., why not go > > ahead with it? > > e.g if it isn't seen as important enough that NB 25 starts on windows / > JDK 24 it could keep using the current launcher which should work a > while longer. > > I am no windows user so I don't really have any stakes in it. It would > be good to keep all target platforms in sync though so that there is > less explaining to do in the readme / download pages etc. > > -mbien > > > > > Gj > > > > On Sun, 15 Dec 2024 at 19:28, Michael Bien <mbie...@gmail.com> wrote: > > > > > Hi again, > > > > > > reminder that the windows launcher can't start on JDK 24ea still. > > > > > > I haven't really pursued it any further since there were no replies in > > > this discussion (and also due to time constrains), but this might block > > > other changes in the NB 25 release cycle. > > > > > > But I ran a quick smoke test today by combining #8009 + #7928 and could > > > start and use NB on windows 10 using JDK 24ea build 28. (for testing > > > purposes you can simply replace the launcher binaries in the netbeans > > > devbuild zip) > > > > > > https://github.com/apache/netbeans/pull/8009#issuecomment-2543968171 > > > > > > feature freeze for NB 25 is likely in about a month and there are > > > holidays in between. Should we proceed with the launcher changes as > > > described in the mail below? > > > > > > -mbien > > > > > > > > > On 30.11.24 00:19, Michael Bien wrote: > > > > Hello, > > > > > > > > now that NB 24 is on its way, lets talk about the next release. > > > > > > > > I think it would be good if NetBeans 25 would be able to run on JDK > > > > 24. To achieve this we have to (finally) deal with the security > > > > manager removal (JEP 486). > > > > > > > > before discussing _how_ the concrete implementation should look, there > > > > are two steps we can do right away: > > > > > > > > 1) remove SM flag from launcher and release new launcher bits > > > > 2) move flag to start config and switch to new launcher bits > > > > > > > > https://github.com/apache/netbeans/pull/8009 (step 1) > > > > > > > > This is essentially the precondition for the next steps otherwise we > > > > can't even influence JVM flags while testing on JDK 24 (on windows at > > > > least). > > > > > > > > The third step is going to be the more interesting discussion given > > > > that we have two proposals for it. > > > > > > > > 3) implement SM removal for JDK 24 compatibility > > > > > > > > I am going to open a separate thread for 3). > > > > > > > > best regards, > > > > > > > > michael > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > > > For additional commands, e-mail: dev-h...@netbeans.apache.org > > > > > > For further information about the NetBeans mailing lists, visit: > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
