Like many folks in this group, I have commit privileges.

As part of the code cleanup work I do, quite often other "issues" pop up
like this, for example.

 [nb-javac]
/home/bwalker/src/netbeans/platform/core.startup/src/org/netbeans/core/startup/layers/BinaryFS.java:545:
warning: [cast] redundant cast to ByteBuffer
 [nb-javac]                 ByteBuffer sub =
(ByteBuffer)content.duplicate().order(ByteOrder.LITTLE_ENDIAN).position(offset);
 [nb-javac]                                  ^

This warning is so straightforward and simple to fix. Basically remove the
cast.

Given that resources are constrained, I wonder if it's "necessary" for me
to submit a code review if all I'm doing is removing the redundant cast.
Rather just merge it?

I ask this question for several reasons: 1 - I really don't want to burden
the group with something as simple as this and 2 - Resources are really
tight and for something as mundane as this, is it really necessary.

Really all I'm looking for here is some guidance that helps.

-brad w.

Reply via email to