On 09/11/2017 05:56 PM, Christian Lenz wrote: > After Netbeans 1st Code donation already landed on git, Who will be > responsible for pull requests? All of us isn’t the correct answer, because > when I do a pull request, someone has to merge it. > > > Regards > > Chris >
Yes and no. Typically, we require 3x+1 (three okays) and NO -1s (those count as a veto) for a merge to a main branch at Apache. That is to say, once three committers on the project have said +1 to a merge (and no one has vetoed it), be it PR or otherwise, then any committer may merge that into the main branch(es). This is known as Review-Then-Commit (RTC). Another approach is Commit-Then-Review (CTR), but that should usually be confined to specific features like documentation or experimental features. in CTR, you commit directly to a main branch, and if someone has a problem with it, they will raise an objection.
