One difference with the previous batch license header change is that now we have a .gitignore file.
Maybe the fact that it's not in there means it's included automatically where before it somehow wasn't. Gj On Mon, Sep 25, 2017 at 12:31 AM, Martin Klähn <[email protected]> wrote: > Strange, yes. > I'm guessing, based on personal experience, that the .DS_Store files are > added once you - as in a mac user - navigate into the folder using the > Finder app. It's just conjunction but did you maybe manually check files in > the folder where such a file exists? > > Martin > > On Mon, Sep 25, 2017 at 12:27 AM, Geertjan Wielenga < > [email protected]> wrote: > > > Yes, strange, the 1st batch change did not include these files: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator- > > netbeans.git;a=commit;h=685504b42d44522d8feb2ad360975160648049c3 > > > > Gj > > > > On Mon, Sep 25, 2017 at 12:24 AM, Geertjan Wielenga < > > [email protected]> wrote: > > > > > Ah, OK, thanks. Weird that they were included, not sure if they were > not > > > included last batch too, then -- and a sign that it's best to do these > > via > > > a fork as well. > > > > > > Gj > > > > > > On Mon, Sep 25, 2017 at 12:22 AM, Martin Klähn <[email protected]> > > > wrote: > > > > > >> Hi Geertjan, > > >> > > >> thanks for doing this work. > > >> > > >> Unfortunately I have a comment regarding your commit. All those newly > > >> added > > >> files, named .DS_Store, do not belong into the commit. Actually they > > >> should > > >> be ignored be the .gitignore file as it os a macOS specific file (see > > >> [1]). > > >> > > >> Beyond this I haven't checked anything else in the commit. > > >> > > >> Regards > > >> Martin > > >> > > >> [1] https://en.wikipedia.org/wiki/.DS_Store > > >> > > >> On Sun, Sep 24, 2017 at 11:53 PM, Geertjan Wielenga < > > >> [email protected]> wrote: > > >> > > >> > Yes, definitely. > > >> > > > >> > Also, by the way, several other modules are affected, inc > > >> performance.java, > > >> > among many others. (The tool is able to print out a list of all > > changed > > >> > files, pretty handy.) > > >> > > > >> > Gj > > >> > > > >> > On Sun, Sep 24, 2017 at 11:49 PM, Dave Schoorl <[email protected]> > > >> wrote: > > >> > > > >> > > I think that's OK. But should the commit text not start with > > >> > [NETBEANS-54] > > >> > > for traceability with the Jira issue? > > >> > > > > >> > > /Dave > > >> > > > > >> > > > > > >> > > > Op 24 september 2017 om 23:42 schreef Geertjan Wielenga < > > >> > > [email protected]>: > > >> > > > > > >> > > > Hi all, > > >> > > > > > >> > > > Today Jan Lahoda finetuned the ASF license converter tool to > > >> catch > > >> > > more > > >> > > > Oracle licenses: > > >> > > > > > >> > > > https://github.com/apache/incubator-netbeans-tools/commit/ > > >> > > 6756d08c0b7b76295a480b5e0335a86c68ae11c2 > > >> > > > > > >> > > > That finetuning results in 1239 files being converted to > > Apache, > > >> > > which is > > >> > > > pretty cool, i.e., the more we can automate the better. From > > >> what I > > >> > > can > > >> > > > tell, all the relicensed files thanks to this particular > > >> finetuning > > >> > > are in > > >> > > > the java.examples and javafx2.samples modules. > > >> > > > > > >> > > > I'll be pushing these license changes in the same way as > > >> previously > > >> > > -- > > >> > > > i.e., directly to incubator-netbeans, and not via a fork. > Hope > > >> > > that's OK > > >> > > > with everyone -- I don't consider these license header > changes > > >> as > > >> > > something > > >> > > > that needs to be reviewed, hence not doing these via a fork > > but > > >> > > making them > > >> > > > directly available to incubator-netbeans. > > >> > > > > > >> > > > Hope that's OK with everyone. > > >> > > > > > >> > > > Gj > > >> > > > > > >> > > > > >> > > > > >> > > > > >> > > Met vriendelijke groet, > > >> > > > > >> > > Dave Schoorl | Java ontwikkelaar |BKWI http://www.bkwi.nl/ | > > >> 06-52749699 > > >> > > | Afwezig op feestdagen en weekenden > > >> > > St. Jacobsstraat 400-420, 3511 BT Utrecht | Postbus 1407, 3500 BK > > >> Utrecht > > >> > > | www.bkwi.nl http://www.bkwi.nl/ > > >> > > > > >> > > > >> > > > > > > > > >
