GitHub user jlahoda opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/8

    [NETBEANS-54] Module Review api.htmlui

    -no external library
    
    -checked Rat report: no license of manifest and signature file (see central 
problems); unconverted license in 
api.htmlui/src/org/netbeans/api/htmlui/HTMLDialog.java (misplaced /*\n, so the 
tool, being strict, refused to convert it. After deleting the '/*\n', the tool 
was happy to convert the header).
    
    -skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jlahoda/incubator-netbeans api.htmlui-review2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit 5becc129a2753d62ca6b787cb34f85b380d260c7
Author: Jan Lahoda <[email protected]>
Date:   2017-09-24T06:20:19Z

    [NETBEANS-54] Module Review api.htmlui
    -no external library
    
    -checked Rat report: no license of manifest and signature file (see central 
problems); unconverted license in 
api.htmlui/src/org/netbeans/api/htmlui/HTMLDialog.java (misplaced /*\n, so the 
tool, being strict, refused to convert it. After deleting the '/*\n', the tool 
was happy to convert the header).
    
    -skimmed through the module, did not notice additional problems

----


---

Reply via email to