GitHub user jlahoda opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/21

    Fixing form files license headers

    There are intentionally 4 separate commits in this pull request:
    1. fixing a typo in two license headers
    2. running the header conversion tool so that it rewrites the license 
header in the two files fixed by the previous commit
    3. running the (new) conversion tool AddFormLicense which adds the Apache 
licence header to form files that have an adjacent java file with the Apache 
license header (it won't touch files that don't have adjacent java files, or if 
the adjacent java file does not have the Apache license header).
    4. excluding form/test/unit/data/goldenfiles/* (form module test data) from 
Rat report
    
    After these, the Rat report shouldn't include any form files.
    
    I have a prototype of a form module change to keep the leading comments in 
form files on modifications (which would keep the license header on 
modification), I'll submit this separately.
    
    Comments are welcome.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jlahoda/incubator-netbeans 
form-files-license-headers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit 557c70d31ffd45f0070aea60fb53c899a88d2ec2
Author: Jan Lahoda <[email protected]>
Date:   2017-09-28T05:27:48Z

    Fixing typos in two license headers.

commit af9caae253ee49f32b6015aeb71a19fb86e4aeca
Author: Jan Lahoda <[email protected]>
Date:   2017-09-28T05:35:40Z

    Applying the header conversion tool to the files fixed by the previous 
commit, so that the license header is re-written for these files.

commit c6d9bafda62db52d4471442589403bc017a7ba45
Author: Jan Lahoda <[email protected]>
Date:   2017-09-28T05:38:21Z

    Adding license header to form files whose adjacent java files have the 
appropriate license header.

commit 3686243742d5c46279e964dd44ffd4f62e1ce3e4
Author: Jan Lahoda <[email protected]>
Date:   2017-09-28T05:47:41Z

    Excluding form test data from Rat.

----


---

Reply via email to