Github user matthiasblaesing commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/23#discussion_r142002449
--- Diff:
db.sql.editor/test/unit/src/org/netbeans/modules/db/sql/editor/completion/SelectCompletionQueryTest.java
---
@@ -125,11 +125,11 @@ public void runTest() throws Exception {
public void testCompletion() throws Exception {
StringBuilder sqlData = new StringBuilder();
- List<String> modelData = new ArrayList<String>();
- BufferedReader reader = new BufferedReader(new
InputStreamReader(SelectCompletionQueryTest.class.getResource(getName() +
".test").openStream(), "utf-8"));
- try {
+ List<String> modelData = new ArrayList<>();
+ try (InputStream is =
SelectCompletionQueryTest.class.getResourceAsStream(getName() + ".test");
+ BufferedReader reader = new BufferedReader(new
InputStreamReader(is, "utf-8"))) {
boolean separatorRead = false;
- for (String line; (line = reader.readLine()) != null;) {
+ for (String line = reader.readLine(); line != null; line =
reader.readLine()) {
--- End diff --
I consider the previous one less readable. The previous version mixed
initialization, loop advance and checking and these parts are now separated
into their corresponding sections.
---
