I think there are two problem with these files: -the tool only looks for the first comment, and the headers in these files are in the second comment, so the tool won't find it. -the tool only looks for comments that begin in the first 100 characters from the beginning (a safety feature, as a few files contain texts of the license headers as patterns)
I'll look at those. Jan On Wed, Oct 4, 2017 at 2:31 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Hi all, > > Yesterday at JavaOne, some of us got together to work on the Modules Review > and found a new pattern that needs to be handled in the converter tool. > > The pattern can be found in several hundred files, so we can clean these > all up at the same time by twesking the tool for this. > > Here are three places where this pattern is found: > > > - api.progress.nb/apichanges.xml > - api.progress/apichanges.xml > - api.progress.nb/apichanges.xml > > > Except, we haven't been able to figure out yet how the pattern (it is a > variation on the standard Oracle license) is different and why it hasn't > been handled by the tool yet. > > Could Jan or someone interested in this question else take a look? > > Geertjan >