Hi Antonio, (my) intent here was to include the -notice.txt file if the given library would need an entry in the NOTICE file. The build then would (although it does not right now) merge the -notice.txt files into the NOTICE file for the given distribution. Source distributions would not have them merged, as they don't directly contain the dependencies, but binary distributions that contain the library would have the -notice.txt added into the NOTICE file.
The description when the NOTICE for a library is required is here: http://www.apache.org/dev/licensing-howto.html On Sun, Oct 8, 2017 at 7:36 AM, Antonio <anto...@vieiro.net> wrote: > Hi all, > > From the list of modules to review I see: > > add "-notice.txt" if needed with any required notices > > a) What does "if needed" exactly mean? When is a notice file required? > b) From [1], > == DO NOT EDIT THIS FILE DIRECTLY. IT IS GENERATED > == BY THE buildnotice TARGET IN THE TOP LEVEL build.xml FILE. > But "buildnotice" is not in NetBeans build.xml. > I believe this notice is copied from the derby library (where they apparently are generating automatically similarly to the above plan). > > So, do we have to add a "-notice.txt" file? When? Or is is automatically > generated somehow? > If the (external) library requires an entry in NOTICE per the policy above, then it should have a -notice.txt, and the build will (hopefully at some point) merge it into a master NOTICE as needed. Jan > > Thanks, > Antonio > > > [1] https://github.com/apache/incubator-netbeans/blob/master/db/ > external/derby-10.2.2.0-notice.txt >
