Unit tests shall be unit tests - e.g. not require special network setup to succeed.
We should find a way to exclude these tests (and some bugzilla one as well) when running: $ ant test One option is @RandomlyFails, other move to test/qa-functional - a place where hard to set up test usually end up. My 2czk -jt Dne 9. 10. 2017 4:47 Craig Russell <[email protected]> napsal(a): > > Setting up a private git repo for the purpose of testing should be possible > by discussing the problem with infra. > > I'd suggest opening an INFRA JIRA ticket with lots of detail as to what is > needed, e.g. > > What are the properties of this git repo? > > Who should administer it? > > Craig > > > On Oct 8, 2017, at 1:39 AM, Antonio <[email protected]> wrote: > > > > See > > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_NETBEANS-2D80&d=DwIFAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=tnLz5-vaI8x9g_xBBlFGf_ldS0-TN1M3i9fMP1FPWgk&m=0jWUhS1yFHCNnzIAOtKLwWGCH4c763tCn9neoFanBow&s=Q8INFtbX-q69Kqng7GYu6XsAkzQUbanI7hCicTBzTLE&e= > > > > > > A git repository with a dummy user & private key are required for the tests > > to succeed. I don't think it's a good idea to have a public repo available > > (with a private key!). So maybe there're some internal Apache repositories > > available for these scenarios. > > > > Cheers, > > Antonio > > > > > > On 08/10/17 09:51, Geertjan Wielenga wrote: > >> Yes, though not sure what those should be changed to. > >> Any ideas? > >> Gj > >> On Sun, Oct 8, 2017 at 8:55 AM, Antonio <[email protected]> wrote: > >>> Hi all, > >>> > >>> libs.git unit tests point to Oracle internal urls (see [1]). > >>> > >>> Would we want to change these urls? Should I open an issue for this? > >>> > >>> Cheers, > >>> Antonio > >>> > >>> [1] > >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dnetbeans_blob_master_&d=DwIFAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=tnLz5-vaI8x9g_xBBlFGf_ldS0-TN1M3i9fMP1FPWgk&m=0jWUhS1yFHCNnzIAOtKLwWGCH4c763tCn9neoFanBow&s=tYJfEavtUOvwrn7629-ZgjAQUs9HhDcnv12QjuVN28U&e= > >>> > >>> libs.git/test/unit/src/org/netbeans/libs/git/jgit/ConnectionTest.java > >>> > > Craig L Russell > [email protected] >
