On 10/10/17 22:31, John McDonnell wrote:
Hi,
So I took on a what I thought would be a quick and simple module to
get into this and I have a few questions:
Module: https://github.com/apache/incubator-netbeans/tree/master/o.eclipse.jgit
1.
The RAT report currently lists:
AL
/home/jenkins/jenkins-slave/workspace/incubator-netbeans-linux/o.eclipse.jgit/build.xml
AL
/home/jenkins/jenkins-slave/workspace/incubator-netbeans-linux/o.eclipse.jgit/external/binaries-list
AL
/home/jenkins/jenkins-slave/workspace/incubator-netbeans-linux/o.eclipse.jgit/nbproject/project.properties
AL
/home/jenkins/jenkins-slave/workspace/incubator-netbeans-linux/o.eclipse.jgit/nbproject/project.xml
build.xml and project.xml files are listed in a "Problems to be solved
centrally" list, so I assume I can ignore them, but in fact, all 4
files listed above have an Apache License header...
I do add Apache license headers to these, I think.
2.
There's 1 external dependency here:
B580E446B543A8DD2F5AA368B07F9C4C9C2E7029
org.eclipse.jgit-3.6.2.201501210735-r_nosignature.jar
I'm not sure about the nosignature part, but I can find[1] this
version which I guess is the same one, but when I change the
binaries-list file to use
B580E446B543A8DD2F5AA368B07F9C4C9C2E7029
org.eclipse.jgit:org.eclipse.jgit:3.6.2.201501210735-r
I got an error as the hash was wrong and had to change it to be:
47D59DFFB5F02470CCFB6C1A5A31B6040A1636E5
org.eclipse.jgit:org.eclipse.jgit:3.6.2.201501210735-r
Should I be viewing this as a potential question mark, or is it okay?
Enter the SHA-1 Checksum at the bottom of this page:
http://search.maven.org/#advancedsearch
And doublecheck that the version (name, etc.) is correct.
If the name of the jar file is different from the original entry you'll
have to update nbproject/project.xml and nbproject/project.properties.
In your case the original file had a '_nosignature' thing there, which
is missing in the file downloaded from central.
For an example of this case of different names you can see
libs.xerces/external/binaries-list (once it's committed). The file
downloaded from maven is xercesImpl-2.8.0.jar, but the original file was
xerces.2.8.0.jar, that name change had to be reflected in
nbproject/project.xml and nbproject/project.properties.
3.
Looking back at[1] it's licensed under EDL. I assume I need to add a file:
org.eclipse.jgit-3.6.2.201501210735-r-notice.txt but I'm unsure what
to include in it/where does its content come from.
I visit the project's repository and then find the proper version. Some
of them have a notice file there, some others (libs.smack, for instance)
don't have one.
Hope this helps,
Antonio
