But I did the same with this one: https://github.com/apache/incubator-netbeans/pull/104
The only difference between that and https://github.com/apache/incubator-netbeans/pull/103 is that 104 has a comment, while 103 was uncommented on. Aside from that, does this mean that we should not be committing to master but to a development branch where someone reviews a PR before accepting it into master? Gj On Wed, Oct 11, 2017 at 11:34 AM, Daniel Gruno <[email protected]> wrote: > On 10/11/2017 12:31 PM, Geertjan Wielenga wrote: > > OK, so I did a PR (https://github.com/apache/incubator-netbeans/pull/103 > ), > > expecting it to be reviewed before someone would manually merge it. > > > > AFAIK, I never merged it myself, I only created a PR. How come was it > > merged? > > https://github.com/apache/incubator-netbeans/commit/ > ed4c03cb13928b6a076f4eac2730704ae2f66a82 > says you committed it to master on the netbeans repo. that counts as > closing the PR, as far as GitHub is concerned. > > > > Gj > > > > On Wed, Oct 11, 2017 at 11:29 AM, Daniel Gruno <[email protected]> > wrote: > > > >> On 10/11/2017 12:28 PM, Geertjan Wielenga wrote: > >>> Hi all, > >>> > >>> Someone appears to automatically (I guess a bot) be merging PRs after a > >>> couple of days of inactivity, i.e., if there are no comments etc, such > as > >>> this one of mine: > >>> > >>> https://github.com/apache/incubator-netbeans/pull/103 > >>> > >>> Is that correct and what we want? I.e., nobody reviewed the above nor > >> asked > >>> any kind of questions about it. > >>> > >>> Gj > >>> > >> > >> asfgit is the synchronization user for the ASF on GitHub. > >> If you merge code related to a PR, then asfgit gets put as the user > >> closing the PR or Issue. > >> > >> > > > >
