Thanks Emmanuel, comments inline... On Oct 11, 2017, at 12:11, ehsavoie <[email protected]> wrote: > > Hi, > About squashing : having a single commit makes it easier to > - backport for maintenance > - revert
Agree to a point there; it is definitely “easier”, having a single value, but cherry picking a range is pretty trivial as well: https://www.tollmanz.com/git-cherry-pick-range/ <https://www.tollmanz.com/git-cherry-pick-range/> Revert and other commands can work with a range too, and getting the range from a point in time relative to a specific merge is pretty easy (especially if there is a PR). The UI for a PR will let one click revert and do the same thing if using GH or Bitbucket as an example. > - review : you don't review some code that might disappear in the next > commit I’m not sure I follow here; that seems always like a possibility if it is one. > Maybe the task should be divided into multiple sub task thus allowing > multiple PRs I agree that is always something someone should review and sub-task, but isn’t the way that will always work out. Thanks, Wade
