Github user junichi11 commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/145#discussion_r144712225
  
    --- Diff: 
apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx
 ---
    @@ -1,41 +1,22 @@
    -<#--
    -DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
    +<!--
    --- End diff --
    
    `<#-- -->` is a freemarker comment: 
http://freemarker.org/docs/dgui_template_overallstructure.html
    `<!-- -->` is a XML/HTML comment.
    
    This difference is important. Templates are processed by freemarker. So if 
`<#-- -->` is used in a template file, generated code does not have the comment 
block(`<#-- -->`). However, `<!-- -->` is used in it, generated code has the 
comment block(`<!-- -->`). In this case, the generated code will have the 
license header.
    
    BTW, if template files are user visible(e.g. Tools > Templates > Select 
Something > Open in editor), probably, we should not add the license header. 
(we should add them to rat excludes.)
    
https://lists.apache.org/thread.html/43bec9e29901ef8d935c2f1515c2b7710c6a7e0b32657c3ddc1468c4@%3Cdev.netbeans.apache.org%3E
 


---

Reply via email to