matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-337703652 @juneau001 as Jun-ichi requested here what needs to be done to get rid of `j2ee.persistence-external-resources.zip`: That file holds XSDs which describe the structure of the XML documents used in JPA. My argument why these files can be part of the source code can be found in the [previous comment](https://github.com/apache/incubator-netbeans/pull/117#issuecomment-336991013). Here is what currently happens: 1. `j2ee.persistence-external-resources.zip` is downloaded into the external directory 2. the `build.xml` of the module declares a `build-init` task, that unzips the files into the folder `./src/org/netbeans/modules/j2ee/persistence/dd/resources/` 3. From that directory these files are included into the final archive So what I would do: - remove the XSDs from the projects `.gitignore` file - expand the contents of the zip as the `build.xml` does (make sure the XSD are in the correct location) - add the source files directly to the repository - remove the whole `external` folder - remove the `build-init` task from `build.xml`, the definition of `persistence.resources.dir` should also be removed Eh voila, you untangled a situation, that needs resolving :-)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
