matthiasblaesing commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338486174 @jlahoda I see nothing that would prevent merging. Some things might be worth looking into later: - use try-with-resource (in many cases this leads to better readability) - eliminate `firstProblem` from `doDownload`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services