vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-338665582 Mmm... I think this is a very simple use case that just compiles a jar file, not enough for a generalization?. I think (I'm not sure) there're other use cases where you need to download several (hopefully binary) jar files in order to be able to compile the patched sources. Maybe we want to explore that use case before making a generalization. Cheers, Antonio 2017-10-23 14:56 GMT+02:00 Jaroslav Tulach <notificati...@github.com>: > *@JaroslavTulach* commented on this pull request. > ------------------------------ > > In o.apache.xml.resolver/build.xml > <https://github.com/apache/incubator-netbeans/pull/172#discussion_r146254955> > : > > > + <!-- ... 2. Unzips maven sources --> > + <unzip src="external/xml-resolver-1.2-sources.jar" dest="build/external-patch/sources" /> > + <!-- ... 3. Applies patch 'external/xml-resolver-1.2-netbeans.patch --> > + <patch dir="build/external-patch/sources" > + patchfile="external/xml-resolver-1.2-netbeans.patch" > + strip="0" /> > + <!-- ... 4. Compiles sources to build/external-patch/classes --> > + <mkdir dir="build/external-patch/classes" /> > + <javac srcdir="build/external-patch/sources" > + destdir="build/external-patch/classes" > > + <exclude name="org/apache/xml/resolver/tests/**" /> > + </javac> > + <!-- ... 5. Creates a jar in 'external/resolver-1.2.jar' --> > + <jar destfile="external/resolver-1.2.jar"> > + <fileset dir="build/external-patch/classes" /> > + </jar> > > Looks like a clean way to solve the need for patches. Should this be more > common, it would be good to move most of the script into projectized.xml > and just configure it with properties from nbproject/project.properties. > > ? > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-netbeans/pull/172#pullrequestreview-71169114>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAibrCchrJZIh4Nw36ScFaSlvwjsT_hFks5svIzmgaJpZM4QBo_-> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
