What's the reason the test will fail if headers are added? Gj
On Mon, Oct 23, 2017 at 5:59 PM, Geertjan Wielenga < [email protected]> wrote: > It seems to me that files in java.hints/test/unit/data/ are all "test data > for which the addition of a source header would cause the tests to fail" -- > i.e., these do not require a license header (https://www.apache.org/legal/ > src-headers.html). > > I think these should be included in the Rat report exclusions. > > Gj > > > On Mon, Oct 23, 2017 at 2:28 PM, Jan Lahoda <[email protected]> wrote: > >> On Mon, Oct 23, 2017 at 12:41 PM, Geertjan Wielenga < >> [email protected]> wrote: >> >> > Hi all, >> > >> > There's about 230 unlicensed Java source files in >> > java.hints/test/unit/data. >> > >> > Before I manually add Apache licenses to all of them manually, is there >> a >> > reason why these weren't licensed to begin with, i.e., will tests fail >> if a >> > license is added to the Java source files? >> > >> >> Most likely yes, tests will most likely (start to) fail if these files are >> changed. If we could avoid adding the headers, that would be the easiest, >> otherwise we will need to deal with the failing tests in the future. >> >> Jan >> >> >> > Thanks, >> > >> > Gj >> > >> > >
