> So in this case it is safe to change the hash, as the class files are not modified and only metadata is affected.
+1 --emi >-------- Original Message -------- >Subject: Re: [MODULE REVIEW] - o.apache.commons.logging - Question >Local Time: October 31, 2017 1:29 PM >UTC Time: October 31, 2017 11:29 AM >From: [email protected] >To: [email protected] > >Hey Arunava, > > Am Dienstag, den 31.10.2017, 16:35 +0530 schrieb Arunava Sinha: >>I was trying to add maven coordinate in >> "o.apache.commons.logging\external\binaries.list" file for download of >> external binary commons-logging-1.1.1.jar. >>So I did the change as below >> -2D859791FBF7D880591864BD4004D8442A8A3B81 commons-logging-1.1.1.jar >> +2D859791FBF7D880591864BD4004D8442A8A3B81 >> commons-logging:commons-logging:1.1.1 >>But build failed with below error >> Download of >>http://central.maven.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar >> produced content with hash 5043BFEBC3DB072ED80FBD362E7CAF00E885D8AE >> when 2D859791FBF7D880591864BD4004D8442A8A3B81 was expected >>Should I change the hash to 5043BFEBC3DB072ED80FBD362E7CAF00E885D8AE. >> I had checked , it is able to download once hash is changed to the new >> value. Please let me know what should be done >> >> when you change the hash you should make sure, that the file contents >> is either identical and the changes are accounted for or the >> functionality is kept intact. >> >> In this case the changes in the hash are caused by differences in the >> ZIP structure and the pom.xml and MANIFEST files. >> >> A tool to make this easier is diffoscope. You can use the website https >> ://try.diffoscope.org that offers that as hosted service. This is the >> result for the two JARs: >> >>https://try.diffoscope.org/zhusppsybqgu.html >> >> So in this case it is save to change the hash, as the class files are >> not modified and only metadata is affected. >> >> Greetings >> >> Matthias
