matthiasblaesing commented on issue #205: NETBEANS-109 fix server generation URL: https://github.com/apache/incubator-netbeans/pull/205#issuecomment-340886742 In general this looks good. My personal preference for the commit message is a short explanation/reasoning for the change, that way a reader can deduce from the commit log why a change was introduced. I suggest to adjust that. The test looks to be modeled following the existing tests and so the structure is generally ok. A comment, that applies to the existing and new tests is, that relying on a specific formatting is IMHO dangerous, using an XML parser and checking the DOM would give a more stable test (this is just an observation and no request for a change). One thing, that should be removed are the superfluous imports.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
