jlahoda opened a new pull request #215: Disabling check for maven coordinates in RatReportTask. URL: https://github.com/apache/incubator-netbeans/pull/215 The RatReportTask is checking that external binaries are downloaded using maven coordinates. While In principle that check is not bad, I'd like to remove it. There's a couple reasons for that: 1. I don't think it is a hard-error at this time to download binaries not using maven coordinates. 2. we have the ant verify-libs-and-licenses working again (for platform at least). This is checking consistency between the license files, binaries and nbbuild/licenses. If at some point it should become a hard error to not download from maven, then verify-libs-and-licenses seems like a better place to do the check. 3. I think it would be cleaner if RatReportTask would just convert the rat report to junit test files, and not do any checks itself. The main driving force behind this patch is that I am trying to set-up a "release" job (a job that produced release artefacts), and I'd like it to run Rat and verify-libs-and-licenses and when the build is passing/blue, we could try to release. And I don't think it is realistic to only use maven coordinates in near enough future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
