emilianbold commented on issue #3: NETBEANS-59 - Document split actions
URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343150815
 
 
   I wrote a rather long message in September. Does nothing I said there make 
sense?
   
   It hard to review a patch that has +320 line and ?101 lines in a single 
commit.
   
   From what I remember and what I deduced while trying to figure it out, you 
just added an `@actionreference` and some helper class then refactored.
   
   Reviewing would be much simpler if refactoring would be a separate commit.
   
   >The last sentence I don't understand in your comment:
   >>So, what I am curious to learn is how does the shortcut work for your 
manually created instance?
   
   I was just curious how the solution even works considering the action is 
created manually and not by the Platform. How does the shortcut plumbing work? 
Because, maybe you don't even need an `@actionreference`?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to