jtulach commented on a change in pull request #2: Add Automatic-Module-Name
attribute to manifest files
URL:
https://github.com/apache/incubator-netbeans-html4j/pull/2#discussion_r150342117
##########
File path: pom.xml
##########
@@ -327,6 +327,7 @@
org.netbeans.html.boot.impl:org.netbeans.html.boot.fx:org.netbeans.html.context.
<instructions>
<Export-Package>${publicPackages},META-INF.services.*;-noimport:=true;-split-package:=first</Export-Package>
<Bundle-SymbolicName>${bundleSymbolicName}</Bundle-SymbolicName>
+
<Automatic-Module-Name>${bundleSymbolicName}</Automatic-Module-Name>
Review comment:
OK, we have a new attribute in `MANIFEST.MF` file. However I'd like to see a
test (e.g. example) what this is good for.
Please note that there is also `Export-Package` attribute. If we really want
to support JDK9, then we shall `export` these packages and make the rest
inaccessible. Can you modify the build script to also properly specify exported
packages?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
