matthiasblaesing commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#issuecomment-343733913 Thank you very much for the work you put in here and the time you took to answer my questions/comments. I rebased the work onto master and squashed the changeset together to improve readability (from experience I know, that there is a need to read comments from commits in the past and a compact commit helps there). A final thought about a public SPI (pluggable PAC evaluation): - a separate SPI module should be created on which the `core.network` would depend on - `PacJsEntryFunction` should be removed from `org.netbeans.core.network.proxy.pac` package, as it is not used in the SPI - `PacScriptEvaluatorNoProxy` and `PacUtils` should be removed from `org.netbeans.core.network.proxy.pac` package, as they are not part of the SPI, but utility classes - Only the `org.netbeans.core.network.proxy.pac` package should be exposed - Usage of interface/class should be unified: `org.netbeans.core.network.proxy.pac.PacHelperMethods` `org.netbeans.core.network.proxy.pac.PacScriptEvaluator` `org.netbeans.core.network.proxy.pac.PacHelperMethodsMicrosoft` `org.netbeans.core.network.proxy.pac.PacHelperMethodsNetscape` `org.netbeans.core.network.proxy.pac.PacScriptEvaluatorFactory` should either be interfaces or abstract classes. With default methods interface can be evolved similar to abstract classes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
