steffendietz commented on issue #279: Restore autoupdate.services tests URL: https://github.com/apache/incubator-netbeans/pull/279#issuecomment-346595065 The tests were fixed by only reverse engineering the missing assets and the use cases they try to simulate. So I'm pretty confident that this is fine for now. However, two of the cases could probably need a more subject-specific review, although it could also happen after the merge, by opening a "reminder" ticket of sorts. 1. The `ExecutablePermissionsTest` checks if there is a `bin` directory with an executable `start.sh` in the user directory, after installing the `executable-permissions` NBM. I'm currently using an installer in the NBM to create this file and make it executable. While this works, I'm not sure if this quite captures the essence of the test, or if it tries to verify some NBM specific behavior, like specifying an executable file in the manifest. (I could not find anything about this, that's why I went with the installer.) 2. The `UpdateUnitFactoryTest.testGroupInstalledAndUpdates` test checks whether one of the installed modules has an update available in the `test-updates-provider` created in the test. The problem I had here is, that there is no test module installed at this point, only real modules, with correct specification versions. I couldn't think of a clean way to always provide an update, if the specification version of the installed modules could *someday* exceed the version available in the static update provider. I still haven't figured this out, but I'm now providing an update with an absurdly high specification version, as mentioned [above](#issuecomment-346498142). Besides these minor gripes I have, everything should be fine. ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
