I think we need to set up guidelines — e.g., a PR must be connected to an issue; a PR must solve a problem and not be cosmetic only; etc.
I’d advise looking at pull/3 by Chris instead. Gj On Thursday, January 11, 2018, Charles Bedon <[email protected]> wrote: > Hello all, > > I was taking a look at this PR: > > https://github.com/apache/incubator-netbeans/pull/361 > > And I was wondering if there's any coding style guidelines document > available somewhere (something like [1]) for NB and NBP development. Did > Oracle have its own set of style guidelines? > > [1] http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html > > Regards, > > Charles Edward Bedón Cortázar > http://www.neotropic.co | Network Management, Data Analysis and Free > Software | twitter.com/neotropic_co > Open Source Network Inventory for the masses! > http://kuwaiba.sourceforge.net | Follow Kuwaiba on Twitter > <http://twitter.com/kuwaiba> > Linux Registered User #386666 > > On Thu, Jan 11, 2018 at 7:01 AM, Geertjan Wielenga < > [email protected]> wrote: > > > Hi all, > > > > The two most urgent actions that need to happen currently -- by anyone > > reading this, yes, this means you! :-) -- are: > > > > 1. VOTE on the release of Apache NetBeans (incubating) Beta 9.0 (but > > only after actually checking the artifact, i.e., building it according > > to the instructions in the README, so that you are actually voting > > meaningfully and looking at the other related files, e.g., > > DEPENDENCIES, for example): > > > > https://lists.apache.org/thread.html/724a57e960ae2103020c22f845585c > > 11a422634a5b823bc66087dea4@%3Cdev.netbeans.apache.org%3E > > > > 2. Review the open pull requests: > > > > https://github.com/apache/incubator-netbeans/pulls > > > > Several have been in the queue for a while, if you have a few minutes, > > and want to pick out a few PRs for review (just read the code and add > > a comment about your opinion on whether it is ready to be merged), > > especially these have been around for a while and need to be wrapped > > up: > > > > https://github.com/apache/incubator-netbeans/pull/3 > > https://github.com/apache/incubator-netbeans/pull/320 > > > > Also, all the other ones too. > > > > Of course, if you don't feel comfortable/knowledgeable enough about > > the related code, then you shouldn't be reviewing the pull request. > > However, if you have NetBeans API experience or have some level of > > coding experience, you should be able to formulate an opinion. > > > > Thanks, > > > > Gj > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > For further information about the NetBeans mailing lists, visit: > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > >
