https://issues.apache.org/jira/browse/NETBEANS-276
On 12/01/18 23:08, Antonio wrote:
I'll open an issue@JIRA with the details.
On 12/01/18 23:07, Antonio wrote:
What Matthias is saying is that the contents of the zip file do not
match github sources in tag 9.0-beta-rc1
You can verify this yourself like so:
# Unzip the sources
cd X
X$ curl -O
https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-java/incubating-9.0-beta/incubating-netbeans-java-9.0-beta-source.zip
X$ mkdir incubating
X$ cd incubating
X/incubating$ unzip ../incubating-netbeans-java-9.0-beta-source.zip
X/incubating$ cd ..
#
X$ git clone [email protected]:apache/incubator-netbeans.git
X$ cd incubator-netbeans
X/incubator-netbeans$ git checkout tags/9.0-beta-rc1
HEAD is now at dd5eb868e... Merge pull request #346 from jherkel/master
# Compute the diff between github and the extracted sources
X/incubator-netbeans$ diff -qr . ../incubating
Only in .: .git
Only in .: .gitattributes
Only in .: .gitignore
Only in .: .travis.yml
Only in ../incubating: DEPENDENCIES
Files ./LICENSE and ../incubating/LICENSE differ
Files ./NOTICE and ../incubating/NOTICE differ
Only in .: form.binding
Only in .: hibernate
Only in .: hibernate4lib
Only in ../incubating/javahelp/external: jhall-2.0_05.jar
Only in ../incubating/libs.junit4/external: hamcrest-core-1.3.jar
Only in ../incubating/libs.junit4/external: junit-4.12.jar
Only in .: libs.svnClientAdapter.svnkit
Only in ../incubating/nbbuild: build
Only in ../incubating/nbbuild/external: apache-rat-0.12.jar
Only in ../incubating/nbbuild/external: apitest.jar
Only in ../incubating/nbbuild/external: langtools-9.zip
Only in ../incubating/nbbuild/external: vanilla-javac-api.jar
Only in ../incubating/nbbuild/external: vanilla-javac-impl.jar
Only in .: o.jdesktop.beansbinding
Only in .: travis-check-line-endings.sh
Note that "form.binding", "hibernate", "hibernate4lib",
"libs.svnClientAdapter.svnkit", "o.jdesktop.beansbinding" exist in "."
(the github repo) but are not in the zipped file. This is correct, as
those modules are ignored from the build, but still exist in github.
But "nbbuild/external/*.jar", "javahelp/external",
"libs.junit4/external/*.jar", etc. should not have been included in
the zip file. Maybe these directories are not probably affected by an
"ant clean"?.
Cheers,
Antonio
On 12/01/18 22:29, Geertjan Wielenga wrote:
Can you be very very clear and concise about what is wrong here? What
does 'Nur in' mean and what exactly is the problem?
Please don't respond with generated texts and so on -- just write down
what it is that is not what it should be or not be.
Thanks,
Gj
On Fri, Jan 12, 2018 at 10:05 PM, Matthias Bläsing
<[email protected]> wrote:
Hey,
my positive findings: The MD5 and SHA1 sums match the artifacts. The
source zip builds cleanly on OpenJDK 8 (the one from Ubuntu artful).
The resulting binary is a usable IDE.
However the git tag is not identical with the contents of the source
zip. That there is contents in the repository that is not in the source
zip would be ok from my POV (hibernate support module for example), but
there are binaries in the source zip.
matthias@athena:~/src/incubator-netbeans$ git branch
* (HEAD losgelöst bei 9.0-beta-rc1)
master
matthias@athena:~/src/incubator-netbeans$ diff -qr . ~/incubating-
netbeans-java-9.0-beta-source
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-source:
DEPENDENCIES.
Nur in .: form.binding.
Nur in .: .git.
Nur in .: .gitattributes.
Nur in .: .gitignore.
Nur in .: hibernate.
Nur in .: hibernate4lib.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/javahelp/external: jhall-2.0_05.jar.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/libs.junit4/external: hamcrest-core-1.3.jar.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/libs.junit4/external: junit-4.12.jar.
Nur in .: libs.svnClientAdapter.svnkit.
Dateien ./LICENSE und /home/matthias/incubating-netbeans-java-9.0-beta-
source/LICENSE sind verschieden.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-source/nbbuild:
build.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/nbbuild/external: apache-rat-0.12.jar.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/nbbuild/external: apitest.jar.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/nbbuild/external: langtools-9.zip.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/nbbuild/external: vanilla-javac-api.jar.
Nur in /home/matthias/incubating-netbeans-java-9.0-beta-
source/nbbuild/external: vanilla-javac-impl.jar.
Dateien ./NOTICE und /home/matthias/incubating-netbeans-java-9.0-beta-
source/NOTICE sind verschieden.
Nur in .: o.jdesktop.beansbinding.
Nur in .: travis-check-line-endings.sh.
Nur in .: .travis.yml.
matthias@athena:~/src/incubator-netbeans$
The jars listed above should not be there. Neither the binaries in
general, nor the GPL-2-CP licensed jar for javahelp should be there.
The LICENSE and NOTICE files in the ZIP and the repository should be
aligned.
So my vote (binding): -1 (don't release)
It should be noted, that I appreciate the work. Until I compared with
the git repository I was about to vote +1, as base test was ok.
Have a nice weekend
Matthias
Am Donnerstag, den 11.01.2018, 00:14 +0100 schrieb Geertjan Wielenga:
Hi all,
Please vote on releasing Apache NetBeans 9.0 Beta (incubating) rc1!
If
this voting passes, another similar voting will be started on
[email protected], and if that passes too, then we can
release this version.
Apache NetBeans 9.0 Beta (incubating) constitutes all the modules in
the Apache NetBeans Git repo, which together provide the NetBeans
Platform (i.e., the underlying application framework), which was
released as Apache NetBeans 9.0 Alpha (incubating), as well as all
the
modules that provide the Java SE-related features of Apache NetBeans.
In short, Apache NetBeans 9.0 Beta (incubating) is a full IDE for
Java
SE development.
Build artifacts available here:
https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-
netbeans-java/incubating-9.0-beta/
The artifact to be voted on:
https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-
netbeans-java/incubating-9.0-beta/incubating-netbeans-java-9.0-beta-
source.zip
Included in the above are the DEPENDENCIES, DISCLAIMER, LICENSE, and
NOTICE
files, as well as a README file with build instructions, which are
the
same as these:
https://github.com/apache/incubator-netbeans/blob/master/README.md
MD5: 4b7df9b329bf17e3b05419eebfa066aa
SHA1: cdf486afbfdad7719c2c0308d78e10562a55422e
Apache NetBeans Git Repo tag: 9.0-beta-rc1
Rat report shows no unknown licenses:
https://builds.apache.org/job/incubator-netbeans-
release/lastSuccessfulBuild/artifact/rat-java-temp/nbbuild/build/rat-
report.txt
Included as a convenience is a binary, unzip it and run it and you'll
see Apache NetBeans:
https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-
netbeans-java/incubating-9.0-beta/incubating-netbeans-java-9.0-beta-
bin.zip
MD5: 8e450ab47bc204fdf17463621f3448bc
SHA1: d64038153c52264ac12f8206aa58e2c76dc3446c
Notable changes:
https://cwiki.apache.org/confluence/display/NETBEANS/Apache+NetBeans+
9.0+Beta
Please try out the package and vote!
The vote is open for a minimum of 72 hours or until the necessary
number of votes (3 binding +1s) is reached.
[ ] +1 Release this package as Apache NetBeans 9.0 Beta (incubating)
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Please add "(binding)" if your vote is binding, i.e., you are an
Apache NetBeans committer, i.e., your name is on this page:
https://wiki.apache.org/incubator/NetBeansProposal, although note the
only real binding votes in the incubator are those of the IPMC, i.e.,
in the next vote thread, after this one passes.
Geertjan
on behalf of the Apache NetBeans team
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: dev-
[email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
