I tested with my app and now it works as expected.
Thank you.

> Il giorno 07 feb 2018, alle ore 22:05, Emilian Bold 
> <emilian.b...@protonmail.ch> ha scritto:
> 
> I've updated the PR. If it's OK, I'll commit it tomorrow or so.
> 
> --emi
> ​
> 
> -------- Original Message --------
> On 7 February 2018 1:21 AM, John McDonnell <mcdonnell.j...@gmail.com> wrote:
> 
>> Hi Emilian,
>> 
>> It's fairly hard to say how long is too long to assume that the user has
>> cancelled the save dialog.
>> 
>> I've been messing around here, and I can see no difference to calling
>> performQuit() or cancelQuit() on the response object (Only tested with JDK8
>> so far)
>> 
>> Can we not then go simplier?
>> and add the line:
>> response.cancelQuit();
>> to both
>> handleQuitRequestWith(QuitEvent e, QuitResponse response)
>> methods?
>> 
>> Since NetBeans handles the shutdown elsewhere after the save dialog is
>> resolved, this doesn't appear to do anything from my rudimentary tests.
>> 
>> (Was going to create a Jira/PR shortly but you beat me to it...)
>> 
>> 
>> Regards
>> 
>> John
>> 
>> 
>> On 6 February 2018 at 23:06, Emilian Bold emilian.b...@protonmail.ch
>> wrote:
>> 
>>> A proper fix would be nice but I just thought of a nice workaround. See
>>> https://github.com/apache/incubator-netbeans/pull/411
>>> --emi
>>> -------- Original Message --------
>>> On 7 February 2018 12:15 AM, Geertjan Wielenga <
>>> geertjan.wiele...@googlemail.com> wrote:
>>>> Yes, a pull request for this would be great -- maybe starting with an
>>>> issue on Apache NetBeans JIRA.
>>>> Gj
>>>> On Tue, Feb 6, 2018 at 11:08 PM, Emilian Bold
>>>> emilian.b...@protonmail.ch wrote:
>>>>> [Also sending this interesting bug to dev@]
>>>>> Hello all,
>>>>> Note this interesting NetBeans bug on macOS: users can't quit the app if
>>>>> they cancelled once!
>>>>> 
>>>>> Might actually explain why sometimes NetBeans prevents Macs from
>>>>> shutting down!
>>>>> 
>>>>> Marco here seems to have (re)discovered it.
>>>>> Anybody want to take a crack at it?
>>>>> --emi
>>>>> -------- Original Message --------
>>>>> On 7 February 2018 12:05 AM, Emilian Bold emilian.b...@protonmail.ch
>>>>> wrote:
>>>>> 
>>>>> 
>>>>>> I does look like a bug in org.netbeans.modules.applemenu.
>>>>>> NbApplicationAdapterJDK8.handleQuitRequestWith(AppEvent.QuitEvent e,
>>>>>> QuitResponse response)
>>>>>> 
>>>>> 
>>>>> 
>>>>>> Seems to me that when the user cancels QuitResponse.cancelQuit should
>>>>>> be called.
>>>>>> 
>>>>> 
>>>>> 
>>>>>> Actually, the Javadoc is quite clear https://docs.oracle.com/
>>>>>> javase/9/docs/api/java/awt/desktop/QuitHandler.html :
>>>>>> 
>>>>> 
>>>>> 
>>>>>> 
>>>>>>> Implementors must call either QuitResponse.cancelQuit(),
>>>>>>> QuitResponse.performQuit(), or ensure the application terminates.
>>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>>> 
>>>>>>> Please report the bug for NETBEANS on the Apache Jira:
>>>>>>> issues.apache.org/jira/
>>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>>> Great find! Seems to me the whole exit action design is unable to send
>>>>>> an answer back in case of cancel.
>>>>>> 
>>>>> 
>>>>> 
>>>>>> I also see this has been reported multiple times in the old Bugzilla:
>>>>>> https://netbeans.org/bugzilla/show_bug.cgi?id=268549
>>>>>> https://netbeans.org/bugzilla/show_bug.cgi?id=271946
>>>>>> https://netbeans.org/bugzilla/show_bug.cgi?id=269724
>>>>>> (probably) https://netbeans.org/bugzilla/show_bug.cgi?id=247690
>>>>>> --emi
>>>>>> -------- Original Message --------
>>>>>> On 6 February 2018 11:22 PM, Marco Rossi ma...@markreds.it wrote:
>>>>>>> Hi Emilian,
>>>>>>> I’ve created this small project (attached here as a zip, hope it’s
>>>>>>> ok) and got the same issue. Please note that this seems to be related 
>>>>>>> to OS
>>>>>>> X only (in Windows it works).
>>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>>> 
>>>>>>> My environment is Netbeans IDE 8.2 on OS X 10.11.6 with Java 1.8.
>>>>>>>> Il giorno 06 feb 2018, alle ore 19:05, Emilian Bold
>>>>>>>> emilian.b...@protonmail.ch ha scritto:
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>>> 
>>>>>>> 
>>>>>>>> Might be something more subtle, I know I could be able to press
>>>>>>>> Cancel with Salvables.
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>>> 
>>>>>>> 
>>>>>>>> Can you create a simple project that reproduces this problem?
>>>>>>>> --emi
>>>>>>>> To unsubscribe, e-mail: users-unsubscr...@netbeans.apache.org
>>>>>>>> For additional commands, e-mail: users-h...@netbeans.apache.org
>>>>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>>>> 
>>>>>>> 
>>>>>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
>>>>> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org
>>>>> For further information about the NetBeans mailing lists, visit:
>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
>>>> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org
>>>> For further information about the NetBeans mailing lists, visit:
>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>> 
>>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
>>> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org
>>> For further information about the NetBeans mailing lists, visit:
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>> 
>> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org
For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to