FYI, I've sent: https://github.com/apache/incubator-netbeans/pull/543
Feedback is welcome. Jan On Thu, May 10, 2018 at 3:53 PM, Jan Lahoda <[email protected]> wrote: > On Thu, May 10, 2018 at 3:26 PM, Emilian Bold <[email protected]> > wrote: > >> What's stopping us to delete it: is the .class file used? >> >> Like I've said, it's trivial. If we don't need it, let's delete it. >> > > I think it is less about what the class is doing, and more how it was > compiled. The classfile version is 45.3, i.e. JDK 1.1 AFAIK. Presumably the > reason is to detect all JDKs installed on a system. As long as we compile > using JDK 8, we may be able to get the same outcome by compiling with > "-target 1.1" (if we are careful enough not to use APIs not in JDK 1.1). > Another example would be java.j2seplatform/probesrc, which is being > compiled in java.j2seplatform/build.xml. > > Jan > > >> --emi >> >> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >> >> On 10 May 2018 4:23 PM, Geertjan Wielenga <geertjan.wielenga@googlemail. >> com> wrote: >> >> > Its not a question of licensing but of compiled source code not being >> allowed to be in the release: >> > >> > https://lists.apache.org/thread.html/73ce8a13d5c13b56c300e4a >> ad1e9e9bc8351ea6e836f5dc60a55cfaa@%3Cgeneral.incubator.apache.org%3E >> > >> > Gj >> > >> > On Thu, May 10, 2018 at 3:04 PM, Emilian Bold < >> [email protected]> wrote: >> > >> > > How do we know the license for TestJDK? Was it not owned by Oracle >> and donated? >> > > >> > > Not sure where it's being used but by looking at the bytecode it's an >> absolutely trivial class we could rewrite at any time. It prints to >> System.out these system properties: >> > > >> > > * java.version >> > > >> > > * java.vm.version >> > > >> > > * java.vendor >> > > >> > > * os.name >> > > >> > > * os.arch >> > > >> > > --emi >> > > >> > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ >> > > >> > > On 10 May 2018 11:30 AM, Geertjan Wielenga < >> [email protected]> wrote:> Hi all,>> Re: >> https://issues.apache.org/jira/browse/NETBEANS-410>> There's still one >> .class file that we have not solved yet:>> nbi/engine/src/org/netbeans/in >> staller/utils/applications/TestJDK.class>> It is still present:>> >> https://github.com/apache/incubator-netbeans/tree/master/ >> nbi/engine/src/org/netbeans/installer/utils/applications>> See the >> related comments by IPMC member Justin Mclean, as part of his rc3>> >> evaluation:>> https://lists.apache.org/threa >> d.html/73ce8a13d5c13b56c300e4aad1e9e9bc8351ea6e836f5dc60a55cfaa@< >> general.incubator.apache.org> >> > > >> > > >> How can we solve this, i.e., can we remove this and if not what >> can be done>> here?>> Thanks,>> Gj---------------------------- >> ----------------------------------------- >> > > >> > > To unsubscribe, e-mail: [email protected] >> > > >> > > For additional commands, e-mail: [email protected] >> ache.org >> > > >> > > For further information about the NetBeans mailing lists, visit: >> > > >> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >> >
